Skip to content

Conversation

@tdixon97
Copy link
Contributor

@tdixon97 tdixon97 commented Jan 5, 2026

This makes it a little easier to use the code outside the simflow by making the metadata and the l200data the arguments to the functions to get pulse pars.

@codecov
Copy link

codecov bot commented Jan 5, 2026

Codecov Report

❌ Patch coverage is 12.06897% with 51 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.22%. Comparing base (026f4b3) to head (ceda106).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
workflow/src/legendsimflow/utils.py 16.12% 26 Missing ⚠️
workflow/src/legendsimflow/hpge_pars.py 13.33% 13 Missing ⚠️
...imflow/scripts/extract_hpge_current_pulse_model.py 0.00% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #42      +/-   ##
==========================================
- Coverage   60.60%   59.22%   -1.39%     
==========================================
  Files          18       18              
  Lines        1051     1084      +33     
==========================================
+ Hits          637      642       +5     
- Misses        414      442      +28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tdixon97 tdixon97 marked this pull request as draft January 7, 2026 14:07
@gipert gipert force-pushed the pulse_par_changes branch from e3c6254 to 89bb8c3 Compare January 8, 2026 12:19
@gipert gipert force-pushed the pulse_par_changes branch from 89bb8c3 to 9e7f068 Compare January 8, 2026 15:53
@tdixon97 tdixon97 marked this pull request as ready for review January 11, 2026 15:42
tdixon97 and others added 2 commits January 12, 2026 05:44
@gipert gipert force-pushed the pulse_par_changes branch from 33007c1 to ceda106 Compare January 12, 2026 13:44
@gipert gipert merged commit b03e46a into legend-exp:main Jan 12, 2026
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants